[libc-commits] [PATCH] D153374: [libc] Remove disabled pass after performance improvement

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Jun 20 13:47:42 PDT 2023


jhuber6 created this revision.
Herald added subscribers: libc-commits, kerbowa, jvesely.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

This pass used to cause huge compile time regressions, That has been
address and can now be re-added.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153374

Files:
  libc/startup/gpu/amdgpu/CMakeLists.txt


Index: libc/startup/gpu/amdgpu/CMakeLists.txt
===================================================================
--- libc/startup/gpu/amdgpu/CMakeLists.txt
+++ libc/startup/gpu/amdgpu/CMakeLists.txt
@@ -26,7 +26,4 @@
   "--target=${LIBC_GPU_TARGET_TRIPLE}"
   "-flto"
   "-Wl,-mllvm,-amdgpu-lower-global-ctor-dtor=0"
-  # FIXME: This pass causes builds to take ~10x longer. Disable until the
-  # performance problems have been addressed.
-  "-Wl,-mllvm,-amdgpu-atomic-optimizations=0"
 )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153374.533035.patch
Type: text/x-patch
Size: 490 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230620/b0539b24/attachment.bin>


More information about the libc-commits mailing list