[libc-commits] [PATCH] D153304: [libc] Remove flexible array and replace with a template
Joseph Huber via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Jun 19 17:51:51 PDT 2023
jhuber6 added inline comments.
================
Comment at: libc/utils/gpu/server/Server.cpp:230
+ state->devices[device_id] = std::make_unique<Device>(lane_size);
+ uint64_t buffer_size =
+ __llvm_libc::rpc::Server<32>::allocation_size(num_ports);
----------------
JonChesterfield wrote:
> The <32> here looks suspect, should allocation size be taking a runtime value for lane size?
Good catch, I'll fix it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153304/new/
https://reviews.llvm.org/D153304
More information about the libc-commits
mailing list