[libc-commits] [PATCH] D152607: [libc][math] Move str method from FPBits class to testing utils.

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jun 9 20:53:34 PDT 2023


lntue created this revision.
lntue added reviewers: michaelrj, sivachandra, phosek.
Herald added projects: libc-project, All.
lntue requested review of this revision.

str method of FPBits class is only used for pretty printing its objects
in tests.  It brings cpp::string dependency to FPBits class, which is not ideal
for embedded use case.  We move str method to a free function in test utils and
remove this dependency of FPBits class.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152607

Files:
  libc/src/__support/FPUtil/CMakeLists.txt
  libc/src/__support/FPUtil/FPBits.h
  libc/src/__support/FPUtil/x86_64/LongDoubleBits.h
  libc/test/UnitTest/CMakeLists.txt
  libc/test/UnitTest/ErrnoSetterMatcher.h
  libc/test/UnitTest/FPMatcher.h
  libc/test/UnitTest/StringUtils.h
  libc/test/src/__support/FPUtil/fpbits_test.cpp
  libc/utils/MPFRWrapper/MPFRUtils.cpp
  utils/bazel/llvm-project-overlay/libc/BUILD.bazel
  utils/bazel/llvm-project-overlay/libc/test/UnitTest/BUILD.bazel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152607.530143.patch
Type: text/x-patch
Size: 28822 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230610/9cad11ee/attachment-0001.bin>


More information about the libc-commits mailing list