[libc-commits] [libc] [libc] disable -Wtype-limits in wctob (PR #74511)

[Schrodinger ZHU Yifan via libc-commits]

================
@@ -29,9 +29,14 @@ LIBC_INLINE cpp::optional<int> wctob(wint_t c) {
   // This needs to be translated to EOF at the callsite. This is to avoid
   // including stdio.h in this file.
   // The standard states that wint_t may either be an alias of wchar_t or
-  // an alias of an integer type, so we need to keep the c < 0 check.
+  // an alias of an integer type where different platforms define this type with
+  // different signedness, so we need to keep the c < 0 check, hence the
+  // pragmas.
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wtype-limits"
   if (c > 127 || c < 0)
----------------
SchrodingerZhu wrote:

Would `(c & ~127) != 0` be better? (maybe not straightforward enough)

https://github.com/llvm/llvm-project/pull/74511