[libc-commits] [PATCH] D148069: [LIBC] Implement remainder of posix 'sched.h' minus `SCHED_SPORADIC`

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

some initial comments, will do a more thorough review later today.



================
Comment at: libc/spec/posix.td:49
+def StructSchedParam : NamedType<"struct sched_param">;
+def StructTimeSpecPtr : PtrType<StructSchedParam>;
+def ConstStructTimeSpecPtr : ConstType<StructSchedParamPtr>;
----------------
this shouldn't be `StructTimeSpecPtr`


================
Comment at: libc/src/sched/linux/sched_get_priority_max.cpp:20
+LLVM_LIBC_FUNCTION(int, sched_get_priority_max, (int policy)) {
+  long ret = __llvm_libc::syscall_impl(146, policy);
+  if (ret < 0) {
----------------
does this syscall not have a name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148069/new/

https://reviews.llvm.org/D148069