[libc-commits] [PATCH] D130966: [libc] Add init and fini array iteration to the loader.

Thorsten via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 3 10:56:52 PDT 2022


tschuett added a comment.

In D130966#3697042 <https://reviews.llvm.org/D130966#3697042>, @sivachandra wrote:

> In D130966#3695678 <https://reviews.llvm.org/D130966#3695678>, @tschuett wrote:
>
>> If libc would support Lit tests, then you could:
>>
>> 1. compile the test binary exactly as you like it
>> 2. inspect the binary with llvm-objdump
>> 3. run the binary and observe the execution as you see fit
>>
>> it would give you higher confidence than forcing loader tests into unit tests.
>
> In general, we are taking small steps (sometimes incomplete) to understand the various infrastructure needs. May be one day we will start using lit-tests. But, unit tests are still very nice :)

No worries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130966/new/

https://reviews.llvm.org/D130966



More information about the libc-commits mailing list