[libc-commits] [PATCH] D106718: [libc] add scudo wrappers to llvm libc

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jul 23 15:22:55 PDT 2021


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/lib/CMakeLists.txt:5
   list(APPEND SCUDO_DEP RTScudoStandalone.${LIBC_TARGET_ARCHITECTURE})
+  list(APPEND SCUDO_DEP RTScudoStandaloneCWrappers.${LIBC_TARGET_ARCHITECTURE})
 endif()
----------------
Nit:
You don't need another call to `list(APPEND ...)`. You add the new library to the previous `list(APPEND ...)` call.
Also, may be call the var `SCUDO_DEPS` (in plural).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106718/new/

https://reviews.llvm.org/D106718



More information about the libc-commits mailing list