[libc-commits] [libc] d4eea5c - [libc][NFC] Add a few casts to suppress loss of precision warnings

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Jan 28 17:16:14 PST 2021


Author: Michael Jones
Date: 2021-01-29T01:16:03Z
New Revision: d4eea5cf0f5d27d978184d70ce3a94e95dad8f01

URL: https://github.com/llvm/llvm-project/commit/d4eea5cf0f5d27d978184d70ce3a94e95dad8f01
DIFF: https://github.com/llvm/llvm-project/commit/d4eea5cf0f5d27d978184d70ce3a94e95dad8f01.diff

LOG: [libc][NFC] Add a few casts to suppress loss of precision warnings

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D95646

Added: 
    

Modified: 
    libc/utils/FPUtil/x86_64/FEnv.h

Removed: 
    


################################################################################
diff  --git a/libc/utils/FPUtil/x86_64/FEnv.h b/libc/utils/FPUtil/x86_64/FEnv.h
index 9e0e2be84614..08379fd446da 100644
--- a/libc/utils/FPUtil/x86_64/FEnv.h
+++ b/libc/utils/FPUtil/x86_64/FEnv.h
@@ -290,11 +290,13 @@ static inline int setRound(int mode) {
     return 1; // To indicate failure
   }
 
-  uint16_t x87Value = bitValue << internal::X87RoundingControlBitPosition;
+  uint16_t x87Value = static_cast<uint16_t>(
+      bitValue << internal::X87RoundingControlBitPosition);
   uint16_t x87Control = internal::getX87ControlWord();
-  x87Control =
-      (x87Control & ~(0x3 << internal::X87RoundingControlBitPosition)) |
-      x87Value;
+  x87Control = static_cast<uint16_t>(
+      (x87Control &
+       ~(uint16_t(0x3) << internal::X87RoundingControlBitPosition)) |
+      x87Value);
   internal::writeX87ControlWord(x87Control);
 
   uint32_t mxcsrValue = bitValue << internal::MXCSRRoundingControlBitPosition;


        


More information about the libc-commits mailing list