[libc-commits] [PATCH] D87516: [libc] Add implementation for hypotf

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Sep 14 12:41:04 PDT 2020


lntue marked 2 inline comments as done.
lntue added inline comments.


================
Comment at: libc/test/src/math/hypotf_test.cpp:21
+
+static const float zero = FPBits::zero();
+static const float negZero = FPBits::negZero();
----------------
hungptit wrote:
> Does const/constexpr work for these global variables?
The template class FPBits<T> does not support constexpr yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87516/new/

https://reviews.llvm.org/D87516



More information about the libc-commits mailing list