[libc-commits] [PATCH] D91817: [libc] Combine all math differential fuzzers into one target.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/fuzzing/math/SingleInputSingleOutputDiff.h:38
+  if (isinf(result1)) {
+    if (isinf(result2) != isinf(result1))
+      __builtin_trap();
----------------
lntue wrote:
> Why these checks are not  isnan(r1) != isnan(r2)
> and isinf(r1) != isinf(r2) ?
Doing this in a different way now.


================
Comment at: libc/fuzzing/math/TwoInputSingleOutputDiff.h:40
+  if (isinf(result1)) {
+    if (isinf(result2) != isinf(result1))
+      __builtin_trap();
----------------
lntue wrote:
> same comment as SingleInputSingleOutput
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91817/new/

https://reviews.llvm.org/D91817