[libc-commits] [PATCH] D79828: [libc] Add implementation of call_once from threads.h.

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/src/threads/linux/call_once.cpp:21
+
+static constexpr unsigned int START = 0x1111;
+static constexpr unsigned int WAITING = 0x2222;
----------------
MaskRay wrote:
> I don't think we need such special magic numbers instead of sequential 0, 1, 2, 3..
> 
> Larger immediates are slower (may require more than one insn) to load on some RISC architectures.
Also, `unsigned int`  -> `unsigned`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79828/new/

https://reviews.llvm.org/D79828