[libc-commits] [PATCH] D76978: [libc builder] Add custom step to run clang-tidy.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Mar 30 14:44:26 PDT 2020


sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: zorg/buildbot/builders/annotated/libc-linux.py:20
+    # Cmake step
+    with step('cmake'):
+        projects = ['llvm', 'libc', 'clang', 'clang-tools-extra']
----------------
Adding clang and clang-tools-extra makes sense ...


================
Comment at: zorg/buildbot/builders/annotated/libc-linux.py:43
+        run_command(['ninja', 'clang-tidy'])
+    with step('run clang-tidy'):
+        tidy_glob = os.path.join(source_dir,'libc', 'src', '**', '**.cpp')
----------------
But, running clang tidy should be driven by our build rules.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76978/new/

https://reviews.llvm.org/D76978





More information about the libc-commits mailing list