[libc-commits] [PATCH] D76412: [libc] Add a simple x86_64 linux loader.

[Petr Hosek via Phabricator via libc-commits]

phosek accepted this revision.
phosek added inline comments.


================
Comment at: libc/test/loader/CMakeLists.txt:40
+
+  if(ADD_LOADER_TEST_DEPENDS)
+  endif()
----------------
Leftover?


================
Comment at: libc/test/loader/CMakeLists.txt:62
+    POST_BUILD
+    COMMAND sh -c ${ADD_LOADER_TEST_ENV} $<TARGET_FILE:${target_name}> ${ADD_LOADER_TEST_ARGS}
+  )
----------------
This is likely going to fail on any non-POSIX systems since there likely won't be `sh` available, should we print a warning in that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76412/new/

https://reviews.llvm.org/D76412