[libc-commits] [PATCH] D75802: [libc] Add sigaction

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Mar 17 00:08:48 PDT 2020


sivachandra added a comment.

I just uploaded https://reviews.llvm.org/D76271. I tested it with this patch to make sure it is working as expected.



================
Comment at: libc/test/src/signal/CMakeLists.txt:20
+    sigaction_test.cpp
+  DEPENDS
+    sigaction
----------------
Add `errno_h` as dependency.


================
Comment at: libc/test/src/signal/sigaction_test.cpp:36
+
+TEST(Sigaction, CustomAction) {
+  // Zero this incase tests get run multiple times in the future.
----------------
This test is crashing for me. I have not investigated why, but GDB is telling me that `SIGUSR1` is not getting caught after line 49.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75802/new/

https://reviews.llvm.org/D75802





More information about the libc-commits mailing list