[libc-commits] [PATCH] D81621: [libc] Remove dead code from memcpy to make it machine independent.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jun 10 16:42:12 PDT 2020


sivachandra created this revision.
sivachandra added a reviewer: gchatelet.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added a project: libc-project.

The dead code was using the x86 "rep movsb" instruction in inline
assembly. The discussion on the patch which added this dead code said
that it can potentially become active depending on machine specific
tuning. We can easily put it back if required in future.

Along that way, platform specific options to memcpy, memset and bzero
builds have been enclosed in conditionals. Also, the optimization level
has been set to -O2 for the memory function builds to actually see the
static functions inlined.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81621

Files:
  libc/src/string/CMakeLists.txt
  libc/src/string/memcpy.cpp
  libc/src/string/x86/memcpy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81621.269997.patch
Type: text/x-patch
Size: 3770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200610/f93d288c/attachment.bin>


More information about the libc-commits mailing list