[libc-commits] [PATCH] D83589: [libc] [Obvious] Remove unneeded header in strchr.

Chris Gyurgyik via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Jul 12 04:52:47 PDT 2020


cgyurgyik added a comment.

In D83589#2145567 <https://reviews.llvm.org/D83589#2145567>, @MaskRay wrote:

> Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:
>
>   arcfilter () {
>           arc amend
>           git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
>   }
>   
>
> `Reviewed By: ` is considered important by some people. Please keep the tag. (`--date=now` is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))
>
> `llvm/utils/git/pre-push.py` can validate the message does not include unneeded tags.


Noted. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83589/new/

https://reviews.llvm.org/D83589





More information about the libc-commits mailing list