[libc-commits] [PATCH] D73472: [libc] Add utils for memory functions

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jan 30 08:50:42 PST 2020


sivachandra added inline comments.


================
Comment at: libc/utils/CPP/ArrayRef.h:84
   iterator begin() const { return data(); }
-  iterator end() const { return data() + size(); }
+  iterator end() const { return data() + ArrayRef<T>::size(); }
 
----------------
gchatelet wrote:
> It's necessary to scope `size`, we can move this to another patch though.
Sorry, I thought I had the a `this->` to go with it. Will land the fix soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73472/new/

https://reviews.llvm.org/D73472





More information about the libc-commits mailing list