[libc-commits] [PATCH] D73452: [libc] Fix benchmarks CMakeLists.txt

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet created this revision.
gchatelet added a reviewer: abrachet.
Herald added subscribers: libc-commits, tschuett, MaskRay, mgorny.
Herald added a project: libc-project.

This is a follow up on https://reviews.llvm.org/rGaba80d0734d1#886881.
`target_link_options` is too recent for current CMake version


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73452

Files:
  libc/utils/benchmarks/CMakeLists.txt


Index: libc/utils/benchmarks/CMakeLists.txt
===================================================================
--- libc/utils/benchmarks/CMakeLists.txt
+++ libc/utils/benchmarks/CMakeLists.txt
@@ -91,9 +91,17 @@
     LibcBenchmark.h
 )
 add_dependencies(libc-benchmark google-benchmark)
-target_include_directories(libc-benchmark PUBLIC "${GOOGLE_BENCHMARK_LIBC_INSTALL}/include")
-target_link_options(libc-benchmark PUBLIC "${GOOGLE_BENCHMARK_LINK_FLAGS}")
-target_link_libraries(libc-benchmark PUBLIC LLVMSupport -lbenchmark Threads::Threads)
+target_include_directories(libc-benchmark
+    PUBLIC
+    "${GOOGLE_BENCHMARK_LIBC_INSTALL}/include"
+)
+target_link_libraries(libc-benchmark
+    PUBLIC
+    "${GOOGLE_BENCHMARK_LINK_FLAGS}" # FIXME: Move to `target_link_options`
+    -lbenchmark                      # FIXME: Move to `target_link_options`
+    LLVMSupport
+    Threads::Threads
+)
 fix_rtti(libc-benchmark)
 
 add_libc_benchmark_unittest(libc-benchmark-test


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73452.240499.patch
Type: text/x-patch
Size: 975 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200127/4954686b/attachment-0001.bin>