[libc-commits] [PATCH] D73302: [libc] Move the implementation of mmap and munmap into a linux specific area.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jan 24 14:36:44 PST 2020


sivachandra added a comment.

In D73302#1837485 <https://reviews.llvm.org/D73302#1837485>, @abrachet wrote:

> LGTM. Would it be appropriate for this patch to add non platform specific implementations that always fail and set errno to ENOSYS in libc/src/sys/mman?


Thats a good idea but I am not yet sure if we want to do this for every function for which we have platform specific implementations. As we add more items, we will see if it make sense to incorporate a pattern like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73302/new/

https://reviews.llvm.org/D73302





More information about the libc-commits mailing list