[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jan 24 14:17:55 PST 2020


sivachandra requested changes to this revision.
sivachandra added a comment.
This revision now requires changes to proceed.

Sorry, I take my acceptance back. I do not think this is required. If you rebase to HEAD of master, it should work without this change. I think, when you reverted the changes to LLVMLibCRules.cmake, you removed LLVMSupport from the list of link libraries for add_libc_unittest targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337





More information about the libc-commits mailing list