[libc-commits] [PATCH] D72353: [libc] Add a convenience CMake rule to add testsuites.

[Alex Brachet via Phabricator via libc-commits]

abrachet added a comment.

This patch is fine but my build fails (unrelated to this patch)

  make[3]: *** No rule to make target 'projects/libc/src/errno/CMakeFiles/__errno_location_objects.dir/errno_location.cpp.o', needed by 'projects/libc/src/errno/__errno_location_raw.o'.  Stop.

But this happened before applying this patch (and after too). On CMake 3.7 and 3.16. Does it build for you?



================
Comment at: libc/test/src/errno/CMakeLists.txt:1
-add_custom_target(libc_errno_unittests)
-add_dependencies(check_libc libc_errno_unittests)
+add_libc_testsuite(libc_errno_unittests)
 
----------------
It seems like the rest of LLVM would call this LibcErrnoUnittests, but I don't care too much for the formatting just thought I would bring it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72353/new/

https://reviews.llvm.org/D72353