[libc-commits] [PATCH] D74653: [libc] Add simple implementations of mtx_lock and mtx_unlock.

Fri Feb 28 13:14:58 PST 2020

sivachandra added a comment.

In D74653#1892046 <https://reviews.llvm.org/D74653#1892046>, @phosek wrote:

> Would it be possible to land the enumeration support separately? These are separate changes and I think it'd be cleaner to land them as two commits.

Done now: https://reviews.llvm.org/D75379

================
Comment at: libc/config/linux/api.td:146
+
+def ThreadsAPI : PublicAPI<"threads.h"> {
+  let TypeDeclarations = [
----------------
phosek wrote:
> Do you plan to graduate these eventually to a common file (and layer Linux on top)? These API aren't Linux specific  and we would like to provide these definitions on other platforms like Fuchsia.
Yes. When we have another platform file, we will put the common parts in a common file.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74653/new/

https://reviews.llvm.org/D74653