[libc-commits] [PATCH] D74897: [libc] Add CMake script to check host cpu features

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCCheckCpuFeatures.cmake:16
+
+function(check_valid_feature feature)
+  if(NOT ${feature} IN_LIST ALL_CPU_FEATURES)
----------------
sivachandra wrote:
> Do we really need this function? We only iterate over the `ALL_CPU_FEATURES` list which is a literal list defined in this file.
Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74897/new/

https://reviews.llvm.org/D74897