[libc-commits] [PATCH] D74502: [libc] Add a README to the sub-directories under the utils directory.

Paula Toth via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Feb 21 18:44:59 PST 2020


PaulkaToast added inline comments.


================
Comment at: libc/utils/CPP/README.md:1
-This directory contains re-implementations of some C++ standard library as well
-as some LLVM utilities. These are to be used with internal LLVM libc code and
-tests. More utilities will be added on an as needed basis. There are certain
-rules to be followed for future changes and additions:
+This directory contains a re-implementations of some C++ standard library, as
+well as some LLVM utilities. These utilities are for use with internal LLVM libc
----------------
"This directory contains re-implementations of some C++ standard library utilities" or "This directory contains a re-implementation of some of the C++ standard library"


================
Comment at: libc/utils/UnitTest/README.md:22
+It is not clear if LLVM libc needs/will need every feature of gtest. We only
+intend to extended it on an _as needed_ basis. Hence, it might never be as
+featureful as gtest.
----------------
"extend" instead of "extended"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74502/new/

https://reviews.llvm.org/D74502





More information about the libc-commits mailing list