[libc-commits] [PATCH] D74948: [libc] Add an optional `NAME` argument to `add_entrypoint_object` rule.

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Feb 20 22:51:53 PST 2020


abrachet accepted this revision.
abrachet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:113
     "REDIRECTED" # Optional argument
-    "" # No single value arguments
+    "NAME" # Single value arguments
     "SRCS;HDRS;DEPENDS"  # Multi value arguments
----------------
Name is also optional, should it's comment say so?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74948/new/

https://reviews.llvm.org/D74948





More information about the libc-commits mailing list