[libc-commits] [PATCH] D85615: [libc] Add strtok implementation.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/string/strtok_test.cpp:61
+  token = __llvm_libc::strtok(nullptr, "_:,_");
+  ASSERT_STREQ(token, nullptr);
+  // Subsequent calls after hitting the end of the string should also return
----------------
cgyurgyik wrote:
> sivachandra wrote:
> > Switch this to `ASSERT_EQ`?
> I get:
> ```
>  no matching function for call to 'test'
>   ASSERT_EQ(token, nullptr);
> ...
> template ignored: deduced conflicting types for parameter 'ValType' ('char *' vs. 'nullptr_t')
>   static bool test(RunContext &Ctx, TestCondition Cond, ValType LHS,
> ```
> Is there an easy fix for this that I'm missing?
Never mind then. I will fix it separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85615/new/

https://reviews.llvm.org/D85615