[libc-commits] [PATCH] D85103: [libc] Add strspn implementation.

Chris Gyurgyik via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 5 08:45:09 PDT 2020


cgyurgyik added inline comments.


================
Comment at: libc/utils/CPP/Bitset.h:36
+                     ? 1
+                     : (NumberOfBits + BitsPerByte - 1) / BitsPerUnit] = {0};
+};
----------------
sivachandra wrote:
> Sorry, I had a typo in my earlier comment. It should have been:
> 
> ```
> (NumberOfBits + BitsPerUnit - 1)/BitsPerUnit
> ```
> 
> This should handle all cases?
Yep! Good call on this. That //should've// been the obvious next step.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85103/new/

https://reviews.llvm.org/D85103



More information about the libc-commits mailing list