[libc-commits] [PATCH] D78612: [libc] Add sanitizer instrumentation to the SIMD strlen implementation.

[Evgenii Stepanov via Phabricator via libc-commits]

eugenis added a comment.

> 1. Should LLVM libc have code which relies on, for example, the undefined behavior like in the implementation of strlen in the change?

IMHO, yes, if you can show meaningful performance improvement on non-synthetic benchmarks.

> 2. Should LLVM libc have hand-crafted sanitizer instrumentation at all? If yes, what should be the criteria to determine whether it is required?

If the answer to the previous question is yes, then it is pretty much required.
Even w/o UB, sanitizers may need source-level help. For example, TSan may need happens-before annotations around atomic-based (or external to the process) synchronization in some cases for correctness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78612/new/

https://reviews.llvm.org/D78612