[libc-commits] [PATCH] D76825: [libc] Move implementations of cosf, sinf, sincosf to src/math directory.

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Apr 14 22:17:37 PDT 2020


abrachet accepted this revision.
abrachet added a comment.
This revision is now accepted and ready to land.

In D76825#1979742 <https://reviews.llvm.org/D76825#1979742>, @sivachandra wrote:

> Thanks a lot for the detailed review.
>
> I did not address some of the comments. The plan is to quickly absorb the AOR code into the normal LLVM-libc way and try to bring AOR developers to work with LLVM-libc. To that extant, I want to keep their structuring as intact as possible so that they do not have to go through a learning phase to understand their own code. We do want the higher-level structuring to adhere to LLVM libc's style so I tried to get that in shape with this change.


Sounds good. LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76825/new/

https://reviews.llvm.org/D76825





More information about the libc-commits mailing list