[libc-commits] [PATCH] D77533: [libc] Make all header comments consistent.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/include/__llvm-libc-common.h:1
-//===------- Common definitions for LLVM-libc public header files- --------===//
+//===-- Common definitions for LLVM-libc public header files- -------------===//
 //
----------------
abrachet wrote:
> Looks like there is a `- ---` which we should make ` ---`. Also should these have `-*- C++ -*-`?
We shouldn't have `C++` here as these are public C headers. The rest of the comment is valid.


================
Comment at: libc/include/__posix-types.h:1
-//===----------------- Definitions of common POSIX types ------------------===//
+//===-- Definitions of common POSIX types ---------------------------------===//
 //
----------------
abrachet wrote:
> Same for the C++ tag here.
Same with C++ here.


================
Comment at: libc/include/ctype.h:1
-//===---------------- C standard library header ctype.h -----------------*-===//
+//===-- C standard library header ctype.h -------------------------------*-===//
 //
----------------
abrachet wrote:
> Here as well, or at least we should remove the `*`
I noticed this as well :)
But really this header should be removed in a separate CL.


================
Comment at: libc/utils/CPP/StringRef.h:9-11
+#ifndef LLVM_LIBC_UTILS_CPP_STRINGREF_H
+#define LLVM_LIBC_UTILS_CPP_STRINGREF_H
 
----------------
abrachet wrote:
> We shouldn't remove the include
Thanks for catching this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77533/new/

https://reviews.llvm.org/D77533