[libc-commits] [PATCH] D71634: Add implementations of POSIX mmap and munmap functions.

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Dec 19 15:31:01 PST 2019


abrachet accepted this revision.
abrachet added a comment.
This revision is now accepted and ready to land.

LGTM. The biggest thing at this stage is if our current implementation will make it such that it is too difficult to change later in the pursuit of supporting more architectures and I don't think that is the case here. Even if our internal handling of `PAGE_SIZE` will change later I think this revision is fine as it is. Wait for someone else to accept too of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71634/new/

https://reviews.llvm.org/D71634





More information about the libc-commits mailing list