[libc-commits] [PATCH] D71094: [libc] Add implementation of errno and define the other macros of errno.h.

[Stan Shebs via Phabricator via libc-commits]

stanshebs added a comment.

In D71094#1775667 <https://reviews.llvm.org/D71094#1775667>, @MaskRay wrote:

> errno is a fundamental component baked in almost every component of a libc and contributors/reviewers should really be on the same page. Both abrachet and stanshebs accepted the patch and they were the initially-added reviewers. I feel a bit lonely to be the only one in the "Request Changes" camp, but I hope you do not commit the patch with these open issues not resolved. To reiterate, I feel strong about my suggested items:
>
> - `__attribute__((visibility("hidden")))` in the internal header.
> - `__attribute__((const))` in the public header.
>
>   They are adopted by both glibc and musl.
>
>   You are reluctant to add hidden visibility because you feel that it may make overlaying llvm-libc on top of system libc harder? Can you discuss more about the details somewhere, e.g. libc-dev or llvm-dev?


My reason to accept this now is that secondary issues like visibility are almost certainly going to need revisiting later, when we have more content to work with.  For instance, do we do it by adding attributes everywhere in sight, or do we build some kind of script or other automation?  Given that this is being developed incrementally from zero, we are just making extra unnecessary work by insisting that the defacto prototype solve all the problems that might need solving in the future.  So let's get the core of the system figured out now, and not worry about secondary issues until more of the system is in place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71094/new/

https://reviews.llvm.org/D71094