<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<div class="">Hi Damian, </div>
<div class=""><br class="">
</div>
<div class="">For a bit broader visibility… </div>
<div class=""><br class="">
</div>
<div class="">We recently added a (temporary?) directory for intrinsic tests under "flang/test/Intrinsics” but we still need to decide how to best integrate it into the testing infrastructure. For now, my vote would be that it is OK to land your tests there
and we can then decide where these tests should live in the long run. Personally, I think the intrinsic specific details (both lowering and “correctness") make a bit more sense as part flang's testing vs. rolling them all the way up to the llvm level. But
that’s just my take — others should chime in if there is a better path… </div>
<div class=""><br class="">
</div>
<div class="">—Pat<br class="">
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div>
<blockquote type="cite" class="">
<div class="">On Jul 20, 2021, at 2:02 AM, Damian Rouson via flang-dev <<a href="mailto:flang-dev@lists.llvm.org" class="">flang-dev@lists.llvm.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" style="caret-color: rgb(0, 0, 0); font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<br class="Apple-interchange-newline">
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Jul 19, 2021 at 11:30 PM Kiran Chandramohan <<a href="mailto:Kiran.Chandramohan@arm.com" class="">Kiran.Chandramohan@arm.com</a>> wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">
<div dir="ltr" class="">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;" class="">
<br class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">>>Am Di., 13. Juli 2021 um 14:59 Uhr schrieb Damian Rouson via flang-dev</span><br class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">>><<a href="mailto:flang-dev@lists.llvm.org" target="_blank" class="">flang-dev@lists.llvm.org</a>>:</span><br style="font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">>>> I'm getting started with writing tests for flang and have a few questions. First, would you recommend contributing tests to the llvm-test-suite repository
at <span class=""> </span></span><a href="https://github.com/llvm/llvm-test-suite?" target="_blank" style="margin: 0px; font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">https://github.com/llvm/llvm-test-suite?</a><br style="font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">
<br style="font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">> Yes, I think the llvm-test-suite should feature more Fortran tests.</span><br style="font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">> See the documentation at [1] and [2] as an example for how tests are</span><br style="font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">> added. For instance, NASA Advanced Supercomputing Parallel Benchmarks</span><br style="font-size: 14.6667px; background-color: rgb(255, 255, 255);" class="">
<span style="font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline;" class="">> [3] could be added.</span><br class="">
<br class="">
If these are tests for Fortran intrinsics then wouldn't the better place be somewhere in the flang directory? Like in unit-tests or something?</div>
</div>
</blockquote>
<div class=""><br class="">
</div>
<div class="">After some discussion offline, I decided to put the tests in the LLVM repository -- presumably the flang directory -- instead of in llvm-test-suite.</div>
<div class=""><br class="">
</div>
<div class="">Damian</div>
</div>
</div>
<span style="caret-color: rgb(0, 0, 0); font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">_______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">flang-dev
mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<a href="mailto:flang-dev@lists.llvm.org" style="font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">flang-dev@lists.llvm.org</a><br style="caret-color: rgb(0, 0, 0); font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev" style="font-family: TrebuchetMS; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev</a></div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>