<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Out-of-tree builds are useful when you're working on more than one thing at once (including trying out other people's changes). You don't need multiple builds of llvm and mlir, just of flang.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> flang-dev <flang-dev-bounces@lists.llvm.org> on behalf of Michael Kruse via flang-dev <flang-dev@lists.llvm.org><br>
<b>Sent:</b> Friday, July 31, 2020 12:01 PM<br>
<b>To:</b> Peter Steinfeld <psteinfeld@nvidia.com><br>
<b>Cc:</b> flang-dev@lists.llvm.org <flang-dev@lists.llvm.org><br>
<b>Subject:</b> Re: [flang-dev] Out-of-tree flang builds</font>
<div> </div>
</div>
<div>
<table bgcolor="#FFEB9C" border="1">
<tbody>
<tr>
<td><font face="verdana" color="black" size="1"><b>External email: Use caution opening links or attachments</b>
</font></td>
</tr>
</tbody>
</table>
<br>
<div>
<div dir="ltr">Support for out-of-tree builds, like BUILD_SHARED_LIBS or gn builds, are helpful for developers, but not relevant for release builds. Requiring to maintain all combinations of build configurations is not feasible before every commit, this is
why they are only best effort. When you notice a out-of-tree build breaking, you are free to fix the problem (and assuming the fix is straightforward, low-risk, without review).
<div><br>
</div>
<div>However, I am wondering, why isn't an iterative build sufficient? Assuming you are not touching any non-flang files, make/ninja should not try to rebuild them.<br>
<div>Michael</div>
<div><br>
</div>
<div><br>
</div>
</div>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">Am Fr., 31. Juli 2020 um 13:41 Uhr schrieb Peter Steinfeld via flang-dev <<a href="mailto:flang-dev@lists.llvm.org">flang-dev@lists.llvm.org</a>>:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div lang="EN-US">
<div class="x_gmail-m_-6764976964683149303WordSection1">
<p class="x_MsoNormal">Out-of-tree builds are a way to build only the flang code using a pre-existing full build of llvm. Out-of-tree flang builds are four times faster than full builds. Thus, for those of us actively developing code and reviewing other people's
changes, out-of-tree builds significantly improve our productivity.<u></u><u></u></p>
<p class="x_MsoNormal"><u></u> <u></u></p>
<p class="x_MsoNormal">Unfortunately, out-of-tree builds are not currently supported by the llvm buildbots. Thus, people changing build files must test this feature themselves. The process of doing an out-of-tree build is described in the flang overview document
-- <a href="https://github.com/llvm/llvm-project/tree/master/flang" target="_blank">
https://github.com/llvm/llvm-project/tree/master/flang</a>. Alternatively, people changing build files could ask someone familiar with out-of-tree builds to review their changes.<u></u><u></u></p>
<p class="x_MsoNormal"><u></u> <u></u></p>
<p class="x_MsoNormal">A recent update from David Truby broke out-of-tree builds --
<a href="https://reviews.llvm.org/D84022" target="_blank">https://reviews.llvm.org/D84022</a>. In the conversation in the Phabricator review, David states that he understands that "out-of-tree builds are considered a "best effort" feature that isn't guaranteed
to work". But since out-of-tree builds are critical for my development, I don't consider them optional.<u></u><u></u></p>
<p class="x_MsoNormal"><u></u> <u></u></p>
<p class="x_MsoNormal">I'm writing this note to bring this issue to the broader flang community. I consider out-of-tree builds to be a critical feature that no change should break. What do you think?<u></u><u></u></p>
</div>
</div>
_______________________________________________<br>
flang-dev mailing list<br>
<a href="mailto:flang-dev@lists.llvm.org" target="_blank">flang-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev</a><br>
</blockquote>
</div>
</div>
</div>
</body>
</html>