<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Johannes,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I didn't realise we could upload the same diff on Phabricator to look at, that's really helpful!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I believe we are looking at lines 320-324 of PFTBuilder.h.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I don't see a real significant difference in the way this is displayed I suppose. Phabricator doesn't pick up that lines 323 and 324 on the right are the same as 312, 322 on the left sans formatting.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
However, I think that even if the formatting was the same Phabricator would display this in the same way as that's just how it displays diffs?<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Maybe Tim can comment on what he thinks of this?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
David Truby<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0);">
<br>
<hr tabindex="-1" style="display:inline-block; width:98%;">
<b>From:</b> Johannes Doerfert<br>
<b>Sent:</b> Thursday, 13 February 2020 21:27<br>
<b>To:</b> David Truby<br>
<b>Cc:</b> David Truby via flang-dev<br>
<b>Subject:</b> Re: [flang-dev] Code formatting alignment with LLVM
<div><br>
</div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 02/13, David Truby via flang-dev wrote:<br>
> Hi all,<br>
> <br>
> Tim Kieth from Nvidia has provided a specific example from the recent<br>
> FIR pull request where the indentation rules caused spurious diffs<br>
> (see this comment:<br>
> <a href="https://github.com/flang-compiler/f18/pull/945#issuecomment-585856610" target="_blank" rel="noopener noreferrer" data-auth="NotApplicable">
https://github.com/flang-compiler/f18/pull/945#issuecomment-585856610</a>).<br>
> <br>
> I'm curious if this is also something that shows up badly in<br>
> Phabricator or if that has a better way of showing diffs involving<br>
> whitespace. Is anyone familiar enough with Phabricator to comment on<br>
> this? I wonder if Phabricator might just be better at handling code<br>
> reviews of this ilk better, meaning that this problem is less visible<br>
> to clang/llvm developers.<br>
> <br>
<br>
Here is the diff:<br>
<a href="https://reviews.llvm.org/differential/diff/244525/" target="_blank" rel="noopener noreferrer" data-auth="NotApplicable">https://reviews.llvm.org/differential/diff/244525/</a><br>
<br>
What line numbers are we looking at again?<br>
<br>
<br>
> Thanks<br>
> David Truby<br>
> <br>
> ________________________________<br>
> From: flang-dev <flang-dev-bounces@lists.llvm.org> on behalf of David Truby via flang-dev <flang-dev@lists.llvm.org><br>
> Sent: 11 February 2020 10:20<br>
> To: flang-dev@lists.llvm.org <flang-dev@lists.llvm.org><br>
> Subject: [flang-dev] Code formatting alignment with LLVM<br>
> <br>
> Hi all,<br>
> <br>
> We have been having a discussion on the GitHub issue tracker about code formatting (and specifically clang-format settings) and whether to align closer with the rest of the project, which you can find here:
<a href="https://github.com/flang-compiler/f18/pull/945" target="_blank" rel="noopener noreferrer" data-auth="NotApplicable">
https://github.com/flang-compiler/f18/pull/945</a>. Since the discussion there hasn’t moved much recently I’d like to start a discussion here so we can get input from a wider group of people.<br>
> <br>
> My opinion is that regardless of technical preferences we shouldn’t diverge from the style of the rest of the project as much as we currently do, or at least if we want to do that then we should have a discussion with the wider community about whether that
is acceptable to them.<br>
> <br>
> Does anyone else have any input on this?<br>
> <br>
> Thanks<br>
> David Truby<br>
<br>
> _______________________________________________<br>
> flang-dev mailing list<br>
> flang-dev@lists.llvm.org<br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev" target="_blank" rel="noopener noreferrer" data-auth="NotApplicable">
https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev</a><br>
<br>
<br>
-- <br>
<br>
Johannes Doerfert<br>
Researcher<br>
<br>
Argonne National Laboratory<br>
Lemont, IL 60439, USA<br>
<br>
jdoerfert@anl.gov<br>
</div>
</span></font></div>
</body>
</html>