<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi Stephen,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">I don’t see any issue with choosing test names, I can confer if you like but the naming of the existing tests have never come into question before, so I doubt anyone would have any particular preferences.
They’re in a separate folder, so make sure the test name isn’t used in the existing tests, then I can’t imagine any problems arising.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">And yes, when all tests are successfully ported, ‘test’ will be removed, and ‘test-lit’ will be renamed to ‘test’ taking its place, and the appropriate changes needed to incorporate this into make
check-all will be needed as well, but should just be as simple as renaming again.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="color:black;mso-fareast-language:EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black;mso-fareast-language:EN-US">Luke<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black;mso-fareast-language:EN-US">Degree Apprentice,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black;mso-fareast-language:EN-US">Arm Manchester
</span><span style="mso-fareast-language:EN-US"><o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Stephen Scalpone <sscalpone@nvidia.com><br>
<b>Date: </b>Wednesday, 15 January 2020 at 23:51<br>
<b>To: </b>Luke Ireland <Luke.Ireland@arm.com><br>
<b>Cc: </b>flang-dev@lists.llvm.org <flang-dev@lists.llvm.org><br>
<b>Subject: </b>Re: [flang-dev] Porting F18 tests to use LLVM lit<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal">Hi Luke,<br>
<br>
During the transition, when writing a lit test, are there any special guidelines beyond choosing a distinct test name?<br>
<br>
After the final step of removing old tests, will you rename the test-lit directory to test?<br>
<br>
Thanks for working on this!<br>
<br>
- Steve<br>
<br>
On 1/15/20, 10:59 AM, "flang-dev on behalf of Doerfert, Johannes via flang-dev" <flang-dev-bounces@lists.llvm.org on behalf of flang-dev@lists.llvm.org> wrote:<br>
<br>
External email: Use caution opening links or attachments<br>
<br>
<br>
Thanks for working on this!<br>
<br>
On 01/15, Luke Ireland via flang-dev wrote:<br>
> Further to the conversation in llvm-dev<<a href="http://lists.llvm.org/pipermail/llvm-dev/2020-January/138282.html">http://lists.llvm.org/pipermail/llvm-dev/2020-January/138282.html</a>>, regarding LLVM testing infrastructure/lit, and the successfully
merged patch from Carol<<a href="https://github.com/flang-compiler/f18/pull/861/commits/1049aeb81e0195d3fa1050b21e93a3980a0b7245">https://github.com/flang-compiler/f18/pull/861/commits/1049aeb81e0195d3fa1050b21e93a3980a0b7245</a>>, we’re continuing development
on adding this infrastructure by porting the existing tests to be compatible with lit.<br>
><br>
> We’d like to propose the following approach:<br>
><br>
> 1. Start off with a new directory, “test-lit” containing lit tests<br>
> 2. make check-all will run this and the old test directory together<br>
> 3. port over all old tests to this new directory as lit tests<br>
> 4. Once all tests are successfully ported, the old directory and test scripts are removed, and “test-lit” becomes “test”.<br>
> 5. All new tests will be created to be compatible with lit.<br>
> During this transition phase, tests can either be written in the old style, and then ported with my script, or preferably, written to work with lit.<br>
<br>
This sounds very reasonable.<br>
<br>
> My PR has three patches:<br>
><br>
> 1. A script which ports old style tests to new lit tests. At the moment it only handles semantic error tests, i.e. tests run with check_error.sh<br>
> 2. The output of the porting script on a subset of the tests for verification. The subset of tests should cover all variations of error tests in my script<br>
> 3. All the remaining error tests from semantics ported to lit.<br>
<br>
Did you look at the llvm/utils/update_XXX_test_checks.py scripts? We<br>
might want to add a scripts there if we can generate, not port, the<br>
CHECK lines.<br>
<br>
Cheers,<br>
Johannes<br>
<br>
> My next steps:<br>
><br>
> 1. Port remaining semantic test types<br>
> * Symbol<br>
> * Generic<br>
> * Modfile<br>
> 2. Port decimal tests<br>
> 3. Port evaluate tests<br>
> 4. Port preprocessing tests (They aren’t in CMakeLists.txt, but are easily portable)<br>
> Each step will come as a pull request in a similar format:<br>
><br>
> 1. Script change to handle new test type<br>
> 2. Ported tests added<br>
> * Either in 2 commits (verified, remaining – likely for changes with a large number of tests)<br>
> * Or all in 1 commit (small number of tests)<br>
> 3. Old style tests removed<br>
> My initial PR is here<<a href="https://github.com/flang-compiler/f18/pull/934">https://github.com/flang-compiler/f18/pull/934</a>>.<br>
><br>
> Thanks,<br>
> Luke<br>
><br>
> Degree Apprentice,<br>
> Arm Manchester<br>
<br>
> _______________________________________________<br>
> flang-dev mailing list<br>
> flang-dev@lists.llvm.org<br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev">https://lists.llvm.org/cgi-bin/mailman/listinfo/flang-dev</a><br>
<br>
<br>
--<br>
<br>
Johannes Doerfert<br>
Researcher<br>
<br>
Argonne National Laboratory<br>
Lemont, IL 60439, USA<br>
<br>
jdoerfert@anl.gov<br>
<br>
<br>
<br>
-----------------------------------------------------------------------------------<br>
This email message is for the sole use of the intended recipient(s) and may contain<br>
confidential information. Any unauthorized review, use, disclosure or distribution<br>
is prohibited. If you are not the intended recipient, please contact the sender by<br>
reply email and destroy all copies of the original message.<br>
-----------------------------------------------------------------------------------<o:p></o:p></p>
</div>
</div>
</body>
</html>