[flang-commits] [flang] [flang][OpenMP] - Transform target offloading directives with dependencies during PFT to MLIR conversion (PR #85130)

Sergio Afonso via flang-commits flang-commits at lists.llvm.org
Thu Mar 14 04:38:08 PDT 2024


================
@@ -946,13 +946,9 @@ genEnterExitUpdateDataOp(Fortran::lower::AbstractConverter &converter,
     cp.processMap(currentLocation, directive, stmtCtx, mapOperands);
   }
 
-  return firOpBuilder.create<OpTy>(
-      currentLocation, ifClauseOperand, deviceOperand,
-      dependTypeOperands.empty()
-          ? nullptr
-          : mlir::ArrayAttr::get(converter.getFirOpBuilder().getContext(),
-                                 dependTypeOperands),
-      dependOperands, nowaitAttr, mapOperands);
+  return firOpBuilder.create<OpTy>(currentLocation, ifClauseOperand,
+                                   deviceOperand, nullptr, mlir::ValueRange(),
----------------
skatrak wrote:

Nit: Add comment to document what these default values refer to.
```suggestion
                                   deviceOperand, /*depends=*/ nullptr, /*depend_vars=*/ mlir::ValueRange(),
```

https://github.com/llvm/llvm-project/pull/85130


More information about the flang-commits mailing list