[flang-commits] [flang] [openmp] [flang][OpenMP] Compile proper `omp_lib.mod` from the `openmp/src/include` sources (PR #80874)

Kiran Chandramohan via flang-commits flang-commits at lists.llvm.org
Wed Mar 6 04:50:07 PST 2024


kiranchandramohan wrote:

> > Please enable the OpenMP runtime in the pre-commit or post-commit CI so that we continue to have testing for those that now require the openmp_runtime.

> One immediate change to make would be to change the buildkite configuration to include "openmp" in the project list right after flang. That would slight increase the build time for each push to PR, as it would then build the OpenMP runtime, too. Not sure if that's desired.

If the post-commit CI of @jplehr is enabled then this is not required at the moment. But I do not think the increase would matter. We might have to check more widely in a discourse post.


> > LG. Please wait for other reviewers.
> > Please enable the OpenMP runtime in the pre-commit or post-commit CI so that we continue to have testing for those that now require the openmp_runtime.
> 
> Hi Kiran, more of an info, I guess: We have a Flang+OpenMP buildbot set up in staging for post-commit testing (https://lab.llvm.org/staging/#/builders/140) of flang and openmp (host + gpu offload). We are working on moving that to production. There will be some more changes and additional coverage coming from our side for pre- and post-commit, though no clear timeline is avail yet.

Thanks, @jplehr, for the info and your work here. It is great to have more testing for OpenMP+Flang upstream. 

> I also talked with Michael offline and made him aware that our bots all build OpenMP as a runtime, which I believe he mentioned makes another change necessary.

Did you mean "necessary" or "unnecessary"?

https://github.com/llvm/llvm-project/pull/80874


More information about the flang-commits mailing list