[flang-commits] [flang] [flang][runtime] Fix integer overflow check in FORMAT (PR #79368)

[Peter Klausler via flang-commits]

================
@@ -214,15 +215,13 @@ template <typename CHAR> void FormatValidator<CHAR>::NextToken() {
   case '7':
   case '8':
   case '9': {
-    int64_t lastValue;
     const CHAR *lastCursor;
     integerValue_ = 0;
     bool overflow{false};
     do {
-      lastValue = integerValue_;
       lastCursor = cursor_;
       integerValue_ = 10 * integerValue_ + c - '0';
-      if (lastValue > integerValue_) {
+      if (integerValue_ > std::numeric_limits<int>::max()) {
----------------
klausler wrote:

The checker in format-implementation.h limited things to 32 bits already.  That seems sufficient to me for repeat counts, field widths, &c. in FORMAT strings.

https://github.com/llvm/llvm-project/pull/79368