[flang-commits] [flang] [mlir] [mlir][TilingInterface] Use `LoopLikeOpInterface` in tiling using SCF to unify tiling with `scf.for` and `scf.forall`. (PR #77874)

via flang-commits flang-commits at lists.llvm.org
Thu Jan 18 17:24:07 PST 2024


MaheshRavishankar wrote:

> Just to clarify, I think this is a good refactoring, I'd just like to see it in the same place as the remaining tiling-related code.
> 
> > I think it depends on what `LoopLikeInterface` should cover.
> 
> Tiling is a quite complex transformation. Implementations of `YieldTiledValuesFn` have to create `tensor.insert_slice` / `tensor.parallel_insert_slice` ops. And tiling only makes sense for specific types (TensorType). At the moment, tiling is nicely isolated in `TilingInterface.td`.

Ok, I dropped this as an interface method.

https://github.com/llvm/llvm-project/pull/77874


More information about the flang-commits mailing list