[flang-commits] [flang] 12c7d4c - [Flang][OpenMP] Remove space before :: in member function definition,… (#78205)

via flang-commits flang-commits at lists.llvm.org
Tue Jan 16 05:09:11 PST 2024


Author: Krzysztof Parzyszek
Date: 2024-01-16T07:09:06-06:00
New Revision: 12c7d4c4b4ddbb9ee407bcfbfb79e47ae1de832a

URL: https://github.com/llvm/llvm-project/commit/12c7d4c4b4ddbb9ee407bcfbfb79e47ae1de832a
DIFF: https://github.com/llvm/llvm-project/commit/12c7d4c4b4ddbb9ee407bcfbfb79e47ae1de832a.diff

LOG: [Flang][OpenMP] Remove space before :: in member function definition,… (#78205)

… NFC

The names were
```
bool DataSharingProcessor ::needBarrier()
void DataSharingProcessor ::insertBarrier()
```

It seems like clang-format treats those as references to the global
namespace instead of separators in a qualified name.

Added: 
    

Modified: 
    flang/lib/Lower/OpenMP.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index 4f7c99a6d2b8405..c770d1c60718c35 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -290,7 +290,7 @@ void DataSharingProcessor::collectSymbolsForPrivatization() {
     TODO(converter.getCurrentLocation(), "Collapse clause with lastprivate");
 }
 
-bool DataSharingProcessor ::needBarrier() {
+bool DataSharingProcessor::needBarrier() {
   for (const Fortran::semantics::Symbol *sym : privatizedSymbols) {
     if (sym->test(Fortran::semantics::Symbol::Flag::OmpFirstPrivate) &&
         sym->test(Fortran::semantics::Symbol::Flag::OmpLastPrivate))
@@ -299,7 +299,7 @@ bool DataSharingProcessor ::needBarrier() {
   return false;
 }
 
-void DataSharingProcessor ::insertBarrier() {
+void DataSharingProcessor::insertBarrier() {
   // Emit implicit barrier to synchronize threads and avoid data races on
   // initialization of firstprivate variables and post-update of lastprivate
   // variables.


        


More information about the flang-commits mailing list