[flang-commits] [flang] [Flang][Parser] Add missing #include "flang/Common/idioms.h" (PR #77484)

Krzysztof Parzyszek via flang-commits flang-commits at lists.llvm.org
Wed Jan 10 06:39:07 PST 2024


https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/77484

>From c8f9ea841ce44e602b6a00348b3d957b3477f118 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
Date: Fri, 5 Jan 2024 13:38:59 -0600
Subject: [PATCH 1/2] [Flang][Parser] Add missing #include
 "flang/Common/idioms.h"

The file format-specification.h uses definitions from Fortran::common,
but doesn't include any headers that provide them.
---
 flang/include/flang/Parser/format-specification.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/flang/include/flang/Parser/format-specification.h b/flang/include/flang/Parser/format-specification.h
index a34e68af2832f3..82bc995a93c484 100644
--- a/flang/include/flang/Parser/format-specification.h
+++ b/flang/include/flang/Parser/format-specification.h
@@ -18,6 +18,8 @@
 // dependences on other parts of the compiler's source code.
 // TODO: support Q formatting extension?
 
+#include "flang/Common/idioms.h"
+
 #include <cinttypes>
 #include <list>
 #include <optional>

>From d8d3f7d7f10dae135243487bebfb1e272f0cb4b8 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
Date: Wed, 10 Jan 2024 08:38:35 -0600
Subject: [PATCH 2/2] Remove blank line

---
 flang/include/flang/Parser/format-specification.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/flang/include/flang/Parser/format-specification.h b/flang/include/flang/Parser/format-specification.h
index 82bc995a93c484..28c8affd7bde02 100644
--- a/flang/include/flang/Parser/format-specification.h
+++ b/flang/include/flang/Parser/format-specification.h
@@ -19,7 +19,6 @@
 // TODO: support Q formatting extension?
 
 #include "flang/Common/idioms.h"
-
 #include <cinttypes>
 #include <list>
 #include <optional>



More information about the flang-commits mailing list