[flang-commits] [flang] [Flang] Allow Intrinsic simpification with min/maxloc dim and scalar result (PR #81619)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Tue Feb 27 07:06:31 PST 2024


tblah wrote:

>     * Is it OK not to diagnose the invalid Dim index at higher optimization levels?
So far as I can tell, the standard does not say what should happen for an invalid DIM index, so I suppose this is fine so long as there's a tangible benefit to skipping this check. @psteinfeld do you have an opinion on this?

Are you skipping this check for performance, or is this just because there isn't a convenient way to output an error message and exit from FIR?

>     * Does the conversion of `fir.convert %[[V1]] : (!fir.heap<!fir.array<1xi32>>) -> !fir.heap<i32>` sound OK to perform?
I believe this should be safe. 

https://github.com/llvm/llvm-project/pull/81619


More information about the flang-commits mailing list