[flang-commits] [flang] [flang][OpenMP] Set OpenMP attributes in MLIR module in bbc before lo… (PR #82774)

via flang-commits flang-commits at lists.llvm.org
Fri Feb 23 07:48:04 PST 2024


agozillon wrote:

> LGTM, nice catch! Seems that as the attribute set expanded we forgot to move this... it's a bit of a pain to keep both bbc and flang in synch at times unfortunately

It does however appear to break a few dozen buildbot tests, but that may be something unrelated in the main branch you have this PR rebased on. Or perhaps the burnside.getModule() line also needs to be moved to below the lower call, at least I hope it's something as simple as that and not the tests acting a lot differently after the attribute movement. 

https://github.com/llvm/llvm-project/pull/82774


More information about the flang-commits mailing list