[flang-commits] [flang] 96b1704 - [flang][runtime] Don't write implied ENDFILE for REC=/POS= (#79637)

[via flang-commits]

Author: Peter Klausler
Date: 2024-02-20T13:41:15-08:00
New Revision: 96b17043507caec02a2ef440b369506122bdeb11

URL: https://github.com/llvm/llvm-project/commit/96b17043507caec02a2ef440b369506122bdeb11
DIFF: https://github.com/llvm/llvm-project/commit/96b17043507caec02a2ef440b369506122bdeb11.diff

LOG: [flang][runtime] Don't write implied ENDFILE for REC=/POS= (#79637)

An implied ENDFILE record, which truncates an external file, should be
written to a sequential unit whenever the file is repositioned for a
BACKSPACE or REWIND statement if a WRITE statement has executed since
the last OPEN/BACKSPACE/REWIND.

But the REC= and POS= positioning specifiers don't apply to sequential
units (they're for direct and stream units, resp.), so don't truncate
the file when they're used.

Added: 
    

Modified: 
    flang/runtime/unit.cpp

Removed: 
    


################################################################################
diff  --git a/flang/runtime/unit.cpp b/flang/runtime/unit.cpp
index 18590567c65eb0..58ca313d9e4454 100644
--- a/flang/runtime/unit.cpp
+++ b/flang/runtime/unit.cpp
@@ -679,6 +679,7 @@ void ExternalFileUnit::Rewind(IoErrorHandler &handler) {
     handler.SignalError(IostatRewindNonSequential,
         "REWIND(UNIT=%d) on non-sequential file", unitNumber());
   } else {
+    DoImpliedEndfile(handler);
     SetPosition(0, handler);
     currentRecordNumber = 1;
     leftTabLimit.reset();
@@ -687,7 +688,6 @@ void ExternalFileUnit::Rewind(IoErrorHandler &handler) {
 }
 
 void ExternalFileUnit::SetPosition(std::int64_t pos, IoErrorHandler &handler) {
-  DoImpliedEndfile(handler);
   frameOffsetInFile_ = pos;
   recordOffsetInFrame_ = 0;
   if (access == Access::Direct) {
@@ -707,6 +707,12 @@ bool ExternalFileUnit::SetStreamPos(
         "POS=%zd is invalid", static_cast<std::intmax_t>(oneBasedPos));
     return false;
   }
+  // A backwards POS= implies truncation after writing, at least in
+  // Intel and NAG.
+  if (static_cast<std::size_t>(oneBasedPos - 1) <
+      frameOffsetInFile_ + recordOffsetInFrame_) {
+    DoImpliedEndfile(handler);
+  }
   SetPosition(oneBasedPos - 1, handler);
   // We no longer know which record we're in.  Set currentRecordNumber to
   // a large value from whence we can both advance and backspace.