[flang-commits] [flang] [Flang][bbc] Prevent bbc -emit-fir command invoking all passes twice (PR #80927)

via flang-commits flang-commits at lists.llvm.org
Thu Feb 8 05:00:43 PST 2024


agozillon wrote:

> Thanks for the changes! Yes I think you have the OpenMP passes in the right place - they should run right after lowering.
> 
> I wonder if we should have a test for the OpenMP pass pipeline similar to `flang/test/Driver/mlir-pass-pipeline.f90`. I'm fine with that remaining out of the scope of this PR though as there apparently wasn't any testing before your changes.

Thank you very much for your help with the PR and the review! Yes, we likely should have added a test like that and it's likely important to add if we end up with more OpenMP specific passes. 

https://github.com/llvm/llvm-project/pull/80927


More information about the flang-commits mailing list