[flang-commits] [flang] [flang][OpenMP][NFC] Further refactoring for `genOpWithBody` & (PR #80839)

Sergio Afonso via flang-commits flang-commits at lists.llvm.org
Tue Feb 6 07:40:45 PST 2024


https://github.com/skatrak commented:

Thanks, this mostly LGTM. I just have a few nits regarding function names and passing the new structure by copy to functions. If there's a reason for the second I'd be curious to know why this is better in this case.

I see a few comment blocks that have been reformatted which doesn't seem like they had to. It adds a bit of noise to the diff, but not sure if that's something that needs addressing.

https://github.com/llvm/llvm-project/pull/80839


More information about the flang-commits mailing list