[flang-commits] [flang] [Flang][OpenMp] Fix to threadprivate not working with host-association. (PR #74966)

[via flang-commits]

https://github.com/NimishMishra approved this pull request.

LGTM. It might be good to add details to the patch summary on the exact approach we took here. Mainly that (1) non-global threadprivate vars are added to `globalSymbols` (since they have implicit SAVE attribute on them), and that (2) during lowering, we skip globalOp creation if there already exists one (this happens in the change you have in OpenMP.cpp).

Currently, we are explicitly creating a threadprivate op in HostAssociations.cpp, and I am not the best person to say whether we are intermixing the two things more than we would like to. Please wait for @kiranchandramohan or someone else to comment on this before merging.

https://github.com/llvm/llvm-project/pull/74966