[flang-commits] [flang] [llvm] [mlir] [Frontend][OpenMP] Refactor getLeafConstructs, add getCompoundConstruct (PR #87247)

[Paul Kirth via flang-commits]

ilovepi wrote:

Hi, we're seeing test failures after this patch in our Linux CI (https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8749923140697717361/overview).

Both `LLVM :: TableGen/directive1.td` and `LLVM :: TableGen/directive2.td are failing` as of at least [14e6f63e](https://llvm.googlesource.com/llvm-project/+/14e6f63ee64711bbd74a0fda745f62f62556d70d). It may have always been broken, but a build failure seems to have hidden the initial problem.

Can you please take a look and revert if this will take a while to fix?

Error output:
```
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: /b/s/w/ir/x/w/llvm_build/bin/llvm-tblgen -gen-directive-decl -I /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/../../include /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td | /b/s/w/ir/x/w/llvm_build/bin/FileCheck -match-full-lines /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td
+ /b/s/w/ir/x/w/llvm_build/bin/FileCheck -match-full-lines /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td
+ /b/s/w/ir/x/w/llvm_build/bin/llvm-tblgen -gen-directive-decl -I /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/../../include /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td
RUN: at line 2: /b/s/w/ir/x/w/llvm_build/bin/llvm-tblgen -gen-directive-impl -I /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/../../include /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td | /b/s/w/ir/x/w/llvm_build/bin/FileCheck -match-full-lines /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td -check-prefix=IMPL
+ /b/s/w/ir/x/w/llvm_build/bin/llvm-tblgen -gen-directive-impl -I /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/../../include /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td
+ /b/s/w/ir/x/w/llvm_build/bin/FileCheck -match-full-lines /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td -check-prefix=IMPL
/b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td:304:15: error: IMPL-NEXT: expected string not found in input
// IMPL-NEXT: llvm::tdl::TDLD_dira, static_cast<llvm::tdl::Directive>(0),
              ^
<stdin>:243:79: note: scanning from here
[[maybe_unused]] static const llvm::tdl::Directive LeafConstructTable[][2] = {
                                                                              ^
<stdin>:244:2: note: possible intended match here
 {llvm::tdl::TDLD_dira, static_cast<llvm::tdl::Directive>(0),},
 ^

Input file: <stdin>
Check file: /b/s/w/ir/x/w/llvm-llvm-project/llvm/test/TableGen/directive2.td

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            .
            .
            .
          238:  } // switch(Dir) 
          239:  llvm_unreachable("Unexpected directive"); 
          240: } 
          241:  
          242: static_assert(sizeof(llvm::tdl::Directive) == sizeof(int)); 
          243: [[maybe_unused]] static const llvm::tdl::Directive LeafConstructTable[][2] = { 
next:304'0                                                                                   X error: no match found
          244:  {llvm::tdl::TDLD_dira, static_cast<llvm::tdl::Directive>(0),}, 
next:304'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:304'1      ?                                                               possible intended match
          245: }; 
next:304'0     ~~~
          246:  
next:304'0     ~
          247: [[maybe_unused]] static auto LeafConstructTableEndDirective = LeafConstructTable + 1; 
next:304'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          248:  
next:304'0     ~
          249: [[maybe_unused]] static const int LeafConstructTableOrdering[] = { 
next:304'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            .
            .
            .
>>>>>>

--
```



https://github.com/llvm/llvm-project/pull/87247