[flang-commits] [flang] [flang][OpenMP] Add OpenMP versions to some tests (PR #89295)

Tom Eccles via flang-commits flang-commits at lists.llvm.org
Mon Apr 22 08:31:47 PDT 2024


tblah wrote:

> It's only certain tests that require a specific version. The new variable is set in a lit config file that applies to all (or many) tests. Do you think we should separate tests into different directories based on the minimum required version?

I was imagining just running all tests on OpenMP 5.2 then overriding it for any specific tests that need an older version. From my perspective, whichever way leaves fewer "special" tests in the long run would be better because it will make the tests which need a particular configuration stand out while avoiding noise on the others.

Separating into different directories sounds good too but I guess it could be more work to maintain.

I don't feel strongly about which approach is best here.

https://github.com/llvm/llvm-project/pull/89295


More information about the flang-commits mailing list